fix(OC_Helper): Use correct binary notation for calculating human file sizes #47711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sizes Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
fix/oc_helper/human-file-size-notation
branch
from
55e5dc0
to
057ca1a
Compare
provokateurin
changed the title
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
Hm so nextcloud-libraries/nextcloud-files#822 sounds like this is intended. @susnux is this PR wrong? |
|
Ok let's just stick to the wrong but established notation. |
|
@provokateurin yes it was decided not to confuse existing users by switch the naming schema: #40621 In general it is a bit difficult, most users are spoiled by Windows using the wrong notation. But then there is Mac which is even weirder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follows proper IEC 60027-2 notation.
Checklist